Ensure collection of stats succeed in a maximum duration to avoid exhausting PG connections #1229
+106
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierresouchay
force-pushed
the
limit_max_duration_of_postgresql_connections_to_avoid_using_too_many_connections
branch
5 times, most recently
from
76203d5 to
f588ca8
Compare
pierresouchay
changed the title
pierresouchay
changed the title
sysadmind
reviewed
Dec 12, 2025
Author
|
@sysadmind I think I addressed all of your concerns, thank you very much for the review |
sysadmind
reviewed
Dec 13, 2025
added 7 commits
December 14, 2025 10:05
**Context**: As explained in prometheus-community#1228, when database is very slow to answer, every call to prometheus exporter might consume a new connection and possibly consume all available connections **Solution**: Ensure a Context with a specified Timeout is specified, so the connection will end if duration of collection is too long Signed-off-by: Pierre Souchay <pierre.souchay@pelico.io>
…should Signed-off-by: Pierre Souchay <pierre.souchay@pelico.io>
…DME.md Signed-off-by: Pierre SOUCHAY <pierre.souchay@pelico.io>
Signed-off-by: Pierre SOUCHAY <pierre.souchay@pelico.io>
Signed-off-by: Pierre SOUCHAY <pierre.souchay@pelico.io>
Signed-off-by: Pierre SOUCHAY <pierre.souchay@pelico.io>
Signed-off-by: Pierre SOUCHAY <pierre.souchay@pelico.io>
pierresouchay
force-pushed
the
limit_max_duration_of_postgresql_connections_to_avoid_using_too_many_connections
branch
from
6240c6f to
ac7050d
Compare
Author
|
@sysadmind I fixed your last concern about the test duration: I think we are good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: As explained in #1228, when database is very slow to answer, every call to prometheus exporter might consume a new connection and possibly consume all available connections
Solution: Ensure a Context with a specified Timeout is specified, so the connection will end if duration of collection is too long
Will fix #1228